fixes #4665 Invalid version details in backend. #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
hrishavjha
approved these changes
Jun 6, 2024
Jonsy13
reviewed
Jun 7, 2024
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
JanhaviAlekar
force-pushed
the
ci-version-error
branch
from
6365b95
to
b0b0b5a
Compare
amityt
approved these changes
Jun 19, 2024
namkyu1999
approved these changes
Jun 24, 2024
Jonsy13
approved these changes
Aug 23, 2024
kwx4957
pushed a commit
to kwx4957/litmus
that referenced
this pull request
Sep 1, 2024
…os#4666) * fix: Invalid version details in backend. Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> * Checking CIVersion at start Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> --------- Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Amit Kumar Das <amit.das@harness.io> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…os#4666) * fix: Invalid version details in backend. Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> * Checking CIVersion at start Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> --------- Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Amit Kumar Das <amit.das@harness.io> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…os#4666) * fix: Invalid version details in backend. Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> * Checking CIVersion at start Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> --------- Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Amit Kumar Das <amit.das@harness.io> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788
pushed a commit
to sagnik3788/litmus
that referenced
this pull request
Oct 5, 2024
…os#4666) * fix: Invalid version details in backend. Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> * Checking CIVersion at start Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> --------- Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Amit Kumar Das <amit.das@harness.io> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4665
Proposed changes
In
updateVersionFormat, Ignored "ci" because it is not a proper version to convert into IntTypes of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: