fix: Refactor ADK store SQL table creation methods to be asynchronous #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done mainly to address issues with Oracle's JSON detection and in-memory flag on creation. - Changed `_get_create_sessions_table_sql` and `_get_create_events_table_sql` methods in various ADK store classes to be asynchronous. - Updated `create_tables` methods to use `execute_script` for executing SQL statements asynchronously. - Modified the Oracle ADK store to support INMEMORY PRIORITY HIGH clause for table creation. - Added tests to verify the correct creation of tables with INMEMORY settings for both async and sync stores. - Updated Litestar configuration to reflect changes in INMEMORY clause handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done mainly to address issues with Oracle's JSON detection and in-memory flag on creation.
_get_create_sessions_table_sqland_get_create_events_table_sqlmethods in various ADK store classes to be asynchronous.create_tablesmethods to useexecute_scriptfor executing SQL statements asynchronously.