Skip to content
This repository was archived by the owner on Apr 3, 2023. It is now read-only.

Removes the v3_0_3 sub-package. #10

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Removes the v3_0_3 sub-package. #10

merged 2 commits into from
Aug 29, 2022

Conversation

peterschutt
Copy link
Contributor

Closes #9

@peterschutt peterschutt requested a review from Goldziher August 28, 2022 23:16
@peterschutt
Copy link
Contributor Author

The main changes are in utils.py - this pr simply removes references to the 3.0.3 stuff from there and any unnecessary variable creation now that we are only dealing with the one schema type. I could refactor it so that the schema types are configurable in the module scope to support if/when we have to support future versions of openapi, but then again, we can just deal with that when the time comes.

Also, made the version 1.1 - do you think that is enough for us, or should we go to v2 for this?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@peterschutt peterschutt merged commit 46a0707 into main Aug 29, 2022
@peterschutt peterschutt deleted the refactor-remove-303 branch August 29, 2022 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Goldziher Goldziher Goldziher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Remove 3.0.3
2 participants
@peterschutt @Goldziher