Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle collections with constrained items #436

Merged
merged 8 commits into from
Nov 12, 2023
Merged

fix: correctly handle collections with constrained items #436

merged 8 commits into from
Nov 12, 2023

Conversation

guacs
Copy link
Member

@guacs guacs commented Nov 12, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

This PR ensures that the constraints for subitems in collection types are parsed correctly.

Close Issue(s)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@guacs guacs marked this pull request as ready for review November 12, 2023 07:41
@guacs guacs requested review from a team as code owners November 12, 2023 07:41
@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/436

@guacs guacs enabled auto-merge (squash) November 12, 2023 11:15
@guacs guacs merged commit 6b7512d into main Nov 12, 2023
21 checks passed
@guacs guacs deleted the annotated-collection-item branch November 12, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCoffee JacobCoffee JacobCoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Annotations for nested types are ignored
2 participants
@guacs @JacobCoffee