fix: don't blindly suppress ValueError (#450)

litestar-org · Dec 8, 2023 · 6961eaa · 6961eaa
1 parent 1a0da0d
commit 6961eaa
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/polyfactory/factories/base.py b/polyfactory/factories/base.py
@@ -492,7 +492,7 @@ def create_factory(
         )
 
     @classmethod
-    def get_constrained_field_value(cls, annotation: Any, field_meta: FieldMeta) -> Any:  # noqa: C901, PLR0911
+    def get_constrained_field_value(cls, annotation: Any, field_meta: FieldMeta) -> Any:  # noqa: C901, PLR0911, PLR0912
         try:
             constraints = cast("Constraints", field_meta.constraints)
             if is_safe_subclass(annotation, float):
@@ -541,16 +541,18 @@ def get_constrained_field_value(cls, annotation: Any, field_meta: FieldMeta) ->
                     pattern=constraints.get("pattern"),
                 )
 
-            with suppress(ValueError):
+            try:
                 collection_type = get_collection_type(annotation)
+            except ValueError:
+                collection_type = None
+            if collection_type is not None:
                 if collection_type == dict:
                     return handle_constrained_mapping(
                         factory=cls,
                         field_meta=field_meta,
                         min_items=constraints.get("min_length"),
                         max_items=constraints.get("max_length"),
                     )
-
                 return handle_constrained_collection(
                     collection_type=collection_type,  # type: ignore[type-var]
                     factory=cls,