fix: properly type hint create_factory (#360)

* fix: properly type hint create_factory * docs: ignore 'F' generic type when building docs
litestar-org · Sep 16, 2023 · 2a20513 · 2a20513
1 parent fc0bf61
commit 2a20513
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/docs/conf.py b/docs/conf.py
@@ -82,6 +82,7 @@
     (PY_CLASS, "Random"),
     (PY_CLASS, "Scope"),
     (PY_CLASS, "T"),
+    (PY_CLASS, "F"),
     (PY_CLASS, "P"),
     (PY_CLASS, "P.args"),
     (PY_CLASS, "P.kwargs"),

diff --git a/polyfactory/factories/base.py b/polyfactory/factories/base.py
@@ -164,6 +164,7 @@ def _create_pydantic_type_map(cls: type[BaseFactory[Any]]) -> dict[type, Callabl
 
 
 T = TypeVar("T")
+F = TypeVar("F", bound="BaseFactory[Any]")
 
 
 class BaseFactory(ABC, Generic[T]):
@@ -487,11 +488,11 @@ def _create_generic_fn() -> Callable:
 
     @classmethod
     def create_factory(
-        cls,
-        model: type,
+        cls: type[F],
+        model: type[T],
         bases: tuple[type[BaseFactory[Any]], ...] | None = None,
         **kwargs: Any,
-    ) -> type[BaseFactory[Any]]:
+    ) -> type[F]:
         """Generate a factory for the given type dynamically.
 
         :param model: A type to model.
@@ -502,7 +503,7 @@ def create_factory(
 
         """
         return cast(
-            "Type[BaseFactory[Any]]",
+            "Type[F]",
             type(
                 f"{model.__name__}Factory",
                 (*(bases or ()), cls),