Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add handler name to exceptions in handler validation. #3575

Merged
merged 7 commits into from
Jun 18, 2024
Merged

feat: add handler name to exceptions in handler validation. #3575

merged 7 commits into from
Jun 18, 2024

Conversation

rafalkrupinski
Copy link
Contributor

Related: #

Description

  • Add handler name to exceptions raise by _validate_handler_function.

Closes

addresses #3548

@github-actions github-actions bot added area/handlers This PR involves changes to the handlers size: small pr/external Triage Required 🏥 This requires triage labels Jun 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (a1f5b3b) to head (ccad48c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3575   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         328      328           
  Lines       14856    14856           
  Branches     2363     2363           
=======================================
  Hits        14599    14599           
  Misses        116      116           
  Partials      141      141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalkrupinski rafalkrupinski changed the title Fix: add handler name to exceptions in handler validation. fix: add handler name to exceptions in handler validation. Jun 16, 2024
@rafalkrupinski rafalkrupinski marked this pull request as ready for review June 16, 2024 11:58
@rafalkrupinski rafalkrupinski requested review from a team as code owners June 16, 2024 11:58
provinzkraut
provinzkraut requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafalkrupinski!

I've left a few suggestions for consistency

litestar/handlers/base.py Outdated Show resolved Hide resolved
litestar/handlers/http_handlers/decorators.py Outdated Show resolved Hide resolved
litestar/handlers/websocket_handlers/route_handler.py Outdated Show resolved Hide resolved
litestar/handlers/websocket_handlers/route_handler.py Outdated Show resolved Hide resolved
litestar/handlers/websocket_handlers/route_handler.py Outdated Show resolved Hide resolved
litestar/handlers/websocket_handlers/route_handler.py Outdated Show resolved Hide resolved
@provinzkraut provinzkraut changed the title fix: add handler name to exceptions in handler validation. feat: add handler name to exceptions in handler validation. Jun 17, 2024
@github-actions github-actions bot added type/feat and removed area/handlers This PR involves changes to the handlers labels Jun 17, 2024
rafalkrupinski and others added 7 commits June 18, 2024 11:53
@rafalkrupinski
fix: add handler name to exceptions in handler validation.
6449f74 
Related: #
@rafalkrupinski @provinzkraut
Update litestar/handlers/http_handlers/decorators.py
292f3a4 
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
@rafalkrupinski @provinzkraut
Update litestar/handlers/websocket_handlers/route_handler.py
42d08ee 
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
@rafalkrupinski @provinzkraut
Update litestar/handlers/websocket_handlers/route_handler.py
149de78 
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
@rafalkrupinski @provinzkraut
Update litestar/handlers/websocket_handlers/route_handler.py
d242322 
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
@rafalkrupinski @provinzkraut
Update litestar/handlers/websocket_handlers/route_handler.py
1d8a50a 
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
@rafalkrupinski
fix: Use handler's __str__() in error messages.
ccad48c 
Related: #
@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3575

@provinzkraut provinzkraut merged commit 3de1b1d into litestar-org:main Jun 18, 2024
25 checks passed
@rafalkrupinski rafalkrupinski deleted the feture/error-source branch June 18, 2024 20:10
Alc-Alc pushed a commit that referenced this pull request Jul 26, 2024
@rafalkrupinski @provinzkraut
feat: add handler name to exceptions in handler validation. (#3575)
5835901 
* fix: add handler name to exceptions in handler validation.



---------

Co-authored-by: Raphael Krupinski <3732079+rafalkrupinski@users.noreply.github.com>
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
@provinzkraut provinzkraut linked an issue Jul 31, 2024 that may be closed by this pull request
Enhancement: Add class and funcion name to ImproperlyConfiguredExceptions #3548
Closed
@provinzkraut provinzkraut mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provinzkraut provinzkraut provinzkraut approved these changes

Assignees
No one assigned
Labels
pr/external size: small Triage Required 🏥 This requires triage type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Add class and funcion name to ImproperlyConfiguredExceptions
2 participants
@rafalkrupinski @provinzkraut