Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing cors headers in response #3179

Merged
merged 5 commits into from
Mar 8, 2024
Merged

fix: missing cors headers in response #3179

merged 5 commits into from
Mar 8, 2024

Conversation

crisog
Copy link
Contributor

@crisog crisog commented Mar 7, 2024

Description

Closes

Closes #3178

@crisog crisog requested review from a team as code owners March 7, 2024 18:52
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (1fb981d) to head (e0e84c8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3179   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         320      320           
  Lines       14425    14431    +6     
  Branches     2322     2324    +2     
=======================================
+ Hits        14171    14177    +6     
  Misses        113      113           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 7, 2024

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3179

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofin
Copy link
Member

cofin commented Mar 8, 2024

@all-contributors add @crisog for bugs, code, and tests

@cofin cofin merged commit e6e7c06 into litestar-org:main Mar 8, 2024
20 checks passed
Copy link
Contributor

@cofin

I've put up a pull request to add @crisog! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: CORS Middleware not setting all headers as per spec
3 participants