fix(3063): Logging middleware with structlog causes application to return HTTP 500 when request body is malformed #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provinzkraut
changed the title
provinzkraut
force-pushed
the
fix-3036-body-parsing-with-structlog
branch
from
61d8008
to
d8f7989
Compare
provinzkraut
changed the title
JacobCoffee
approved these changes
Feb 13, 2024
provinzkraut
force-pushed
the
fix-3036-body-parsing-with-structlog
branch
from
d8f7989
to
2771a53
Compare
provinzkraut
force-pushed
the
fix-3036-body-parsing-with-structlog
branch
from
a9ad825
to
795addb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 320 320
Lines 14373 14387 +14
Branches 2310 2313 +3
=======================================
+ Hits 14123 14137 +14
Misses 109 109
Partials 141 141 ☔ View full report in Codecov by Sentry. |
|
4 tasks
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully handle malformed request bodies during parsing when using struclog. Instead of erroring out and returning a
500, simply use the raw body.Fixes #3063.