Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprectated property #3087

Merged
merged 3 commits into from
Feb 10, 2024
Merged

fix: replace deprectated property #3087

merged 3 commits into from
Feb 10, 2024

Conversation

cbscsm
Copy link
Contributor

@cbscsm cbscsm commented Feb 8, 2024

  • Litestar.static_files_config property is deprecated since 2.6.0 by feat: Implement static file serving with regular route handlers #2960
  • But Litestar.__init__ uses the property. I'm not sure that it is intended or not, I can't avoid that deprecated warning from calling Litestar(...).
    DeprecationWarning: Use of deprecated property 'static_files_config'. Deprecated in litestar 2.6.0. This property will be removed in the next major version. Use create_static_files router instead
    
  • I suggest replace the property access to internal attribute in internal code.

@cbscsm cbscsm requested review from a team as code owners February 8, 2024 04:08
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1aee828) 98.27% compared to head (fb297a7) 98.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3087   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         320      320           
  Lines       14353    14353           
  Branches     2306     2306           
=======================================
  Hits        14106    14106           
  Misses        107      107           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guacs
Copy link
Member

guacs commented Feb 8, 2024

@cbscsm the failing build should be fixed by #3089.

@guacs guacs enabled auto-merge (squash) February 8, 2024 17:19
@guacs guacs merged commit 1526be3 into litestar-org:main Feb 10, 2024
19 checks passed
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3087

bunny-therapist pushed a commit to bunny-therapist/litestar that referenced this pull request Feb 12, 2024
fix: Replace deprectated property

Co-authored-by: guacs <126393040+guacs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants