chore: Adds deprecation warnings for app parameter when using to_asgi_response method of responses
#2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse method of responses
…esponse method of responses
Refactor/2217
provinzkraut
requested changes
Sep 1, 2023
…dated the type for app to allow for it to be None, replaced usage of app in to_asgi_response to be None
fix: made the app deprecation calls only trigger when app is used
…ate_enginer, added it
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2268 |
|
@provinzkraut just pinging you for another review :) |
provinzkraut
requested changes
Sep 6, 2023
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
|
please resolve the last comment @wevonosky |
|
@Goldziher and @provinzkraut I left a comment on why I had to modify that test. @all-contributors please add @wevonosky |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors please add @wevonosky for code |
|
I've put up a pull request to add @wevonosky! 🎉 |
Goldziher
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
This PR adds deprecation warnings for the use of
appin theto_asgi_responsemethods of responses. Theappparameter is redundant since therequestparameter has the associated app available.Close Issue(s)
Closes #2217