update(ui): update validation of phone to be globally #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoehabb
requested changes
Oct 28, 2025
Collaborator
mmoehabb
left a comment
mmoehabb
left a comment
There was a problem hiding this comment.
Great work. I have just one comment please give it a look.
|
|
||
| export function validatePhoneGlobally( | ||
| phone: string, | ||
| region?: string |
Collaborator
There was a problem hiding this comment.
Why the region is optional?
I think we should make it required in order to be able to spot the places where it must be modified allover the codebase. Moreover, it should have a more specific type rather than 'string'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary