Skip to content

Conversation

@moalidv
Copy link
Collaborator

@moalidv moalidv commented Oct 19, 2025

Summary

Render timer to the next lesson in alternative with subscribtion quote.
Navbar is removed from both chat page with active chat room and lesson page.

Cases that should be tested:

  • subscribed without lesson
  • subscribed with upcoming lesson before the lesson with more than three minutes
  • subscribed with upcoming lesson before the lesson with less than three minutes
  • subscribed with upcoming lesson after the lesson started
  • subscribed with upcoming lesson after the lesson ended
  • unsubscribed without lesson
  • unsubscribed with upcoming lesson before the lesson with more than three minutes
  • unsubscribed with upcoming lesson before the lesson with less than three minutes
  • unsubscribed with upcoming lesson after the lesson started
  • unsubscribed with upcoming lesson after the lesson ended
  • chat page
  • lesson page

@moalidv moalidv self-assigned this Oct 19, 2025
@moalidv moalidv force-pushed the mo/navbar-update branch 2 times, most recently from dcc8aec to c3affca Compare October 20, 2025 18:26
@moalidv moalidv requested a review from mmoehabb October 20, 2025 18:27
@moalidv moalidv added the enhancement New feature or request label Oct 20, 2025
@moalidv moalidv marked this pull request as ready for review October 20, 2025 18:32
Copy link
Collaborator

@mmoehabb mmoehabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Subscribe now is not shown in the desktop screen.
  • The bar doesn't look professional on relativily large phone screens, or tablets.
  • The text should take all required space in large screens.
  • Make the counter appears just like the design. There should be more space(s) between the digits.
  • The timer is hidden for a couple seconds when the page starts loading (try to refresh the page while it's counting).
  • The timer appears like this: "0 : NaN : NaN" when the session time is close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants