Skip to content

Resolved #8359: Versión 4.0 objectscriptquality #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martalite merged 1 commit into from
Jul 7, 2025
Merged

Resolved #8359: Versión 4.0 objectscriptquality #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/main/java/com/github/fge/grappa/run/ParsingResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,6 @@ public ParsingResult(final boolean matched,
*/
public boolean isSuccess()
{
int index = contextIndex;
while (index < inputBuffer.length()) {
char c = inputBuffer.charAt(index);
if (c != '\n') {
return false; // cualquier cosa que no sea '\n' invalida el parseo completo
}
index++;
}
return matched;
}

Expand Down
16 changes: 0 additions & 16 deletions src/test/java/com/github/fge/grappa/run/ParseRunnerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,4 @@ public void basicParseRunnerCanReliablyReportErrors()
assertThat(runner.run("bbb").isSuccess()).as("errors are reported")
.isFalse();
}

@Test
public void incompleteMatchIsReportedAsFailure()
{
assertThat(runner.run("aab").isSuccess())
.as("incomplete match is a failure")
.isFalse();
}

@Test
public void completeMatchIsASuccess()
{
assertThat(runner.run("aaaa").isSuccess())
.as("complete match is a success")
.isTrue();
}
}