Fixing serialization errors on BinanceApi #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make special_tips and several other fields in NetworkInfo optional to match the actual response format from Binance API. This resolves deserialization errors when parsing API responses.
Implement a custom deserializer for the Permission enum to properly handle string values from the Binance API response.
Update order parameters in the cross-chain executor to correctly set quote_order_qty for BUY orders and quantity for SELL orders based on order side.
Kailai-Wang
approved these changes
Apr 16, 2025
silva-fj
added a commit
that referenced
this pull request
Apr 16, 2025
* fix(binance-api): update NetworkInfo field types Make special_tips and several other fields in NetworkInfo optional to match the actual response format from Binance API. This resolves deserialization errors when parsing API responses. * fix(binance-api): add custom Permission deserializer Implement a custom deserializer for the Permission enum to properly handle string values from the Binance API response. * feat(binance): improve order handling and type support Update order parameters in the cross-chain executor to correctly set quote_order_qty for BUY orders and quantity for SELL orders based on order side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes serialization issues with
wallet::get_all_coins_infoandspot_trading::get_account_infoBinanceApi methods.The parameters to create orders have been updated to set the quantity to sell/buy