Skip to content

fix manifest + minor changes #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

fix manifest + minor changes #3397

merged 4 commits into from
Apr 15, 2025

Conversation

BillyWooo
Copy link
Collaborator

  • fix manifest
  • some minor update

@BillyWooo BillyWooo requested a review from kziemianek April 15, 2025 09:32
kziemianek
kziemianek approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume sgx.allowed_files is just a workaround.

@Kailai-Wang
Copy link
Collaborator

I assume sgx.allowed_files is just a workaround.

Yes we should explicit mount them I guess - for now it's fine

@BillyWooo BillyWooo merged commit 0c4b42d into dev Apr 15, 2025
12 checks passed
@BillyWooo BillyWooo deleted the some-minor-change branch April 15, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kziemianek kziemianek kziemianek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillyWooo @Kailai-Wang @kziemianek