Skip to content

Fix GET method paramether query #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2025
Merged

Fix GET method paramether query #3390

merged 5 commits into from
Apr 14, 2025

Conversation

Kailai-Wang
Copy link
Collaborator

Context

As topic - we should use parameter queries.

It also uses Url::join to avoid double slash.

@Kailai-Wang Kailai-Wang requested review from kziemianek, silva-fj, BillyWooo and a team April 14, 2025 19:15
@Kailai-Wang Kailai-Wang self-assigned this Apr 14, 2025
@BillyWooo BillyWooo merged commit d94ab88 into dev Apr 14, 2025
21 checks passed
@BillyWooo BillyWooo deleted the http-get-params branch April 14, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyWooo BillyWooo BillyWooo approved these changes

@kziemianek kziemianek Awaiting requested review from kziemianek

@silva-fj silva-fj Awaiting requested review from silva-fj

Assignees

@Kailai-Wang Kailai-Wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kailai-Wang @BillyWooo