-
Notifications
You must be signed in to change notification settings - Fork 18
Take gas fee into account for cross chain trade #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take gas fee into account for cross chain trade #3377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok that full amount is paid out by accounting contract ?
Shouldn't it take gas fee into amount?
@kziemianek The accounting contract is triggered by worker, so the worker will pay gas. The only exception is the swap process errors out after paying out but before calling pumpx. In that case, yes we'll lose the gas fee we paid, but we consider the fee minimal and case is rare, so we live with it in the first version |
Context
As topic - we should call pumpx api with adjusted
amount_in
.