Implement cross chain swaps by silva-fj · Pull Request #3364 · litentry/heima

silva-fj · 2025-04-11T00:36:51Z

TODO:

Create map for binance assets.
Transfer from_asset to binance deposit address (from user's OmniAccount)
Make the trade using binance spot trading api from_asset => BNB and notify BE in case of errors.
Transfer assets back to OmniAccount if binance trade fails.
Call accounting contract on BSC. (may need some help from @felixfaisal)
Make native trade with pumpx API (using market order)

Note: the following trades are the only ones supported.

USDT@solana -> BNB
USDC@solana -> BNB
SOL@solana -> BNB

…n executor

Implement initial Binance API integration in the cross-chain executor

linear · 2025-04-11T00:36:54Z

P-1395 Intent processing (cross-chain swap)

Add RemoteSigner implementation that connects to the pumpx signer service for securely signing Solana transactions.

Update RemoteSigner implementation to receive a tokio runtime Handle through constructor rather than retrieving it internally.

Extract Solana functionality into a dedicated module

Add SolanaClient implementation that provides functionality for: - Transferring SOL to specified addresses - Transferring SPL tokens between wallets - Managing transaction signing and confirmations - Error handling and logging for transaction failures This extends the Solana module with client capabilities needed for cross-chain swaps and other DeFi operations.

executor

…ng-cross-chain-swap

Add integration with Binance spot trading API for cross-chain swaps: - Expose Binance API types needed for order creation - Implement market order creation with appropriate trading pairs - Add status monitoring to verify order execution - Implement error handling with failure notifications - Support USDC, USDT and SOL pairs with BNB

Add Ethereum accounting contract integration to cross-chain swaps: - Add AccountingContractClient as a dependency to relevant crates - Initialize accounting contract client with Ethereum RPC provider - Set up contract address in executor initialization - Update cross-chain executor to use accounting client - Implement proper type parameters for RPC providers

Kailai-Wang

Thank you - I think the flow is fine - I have a few details to discuss

Kailai-Wang · 2025-04-12T19:45:41Z

+			let ethereum_rpc_provider = ethereum_rpc::AlloyRpcProvider::new(&args.ethereum_url);
+			let accounting_contract_client = AccountingContractClient::new(
+				ethereum_rpc_provider,
+				"TODO:get contract address".parse().unwrap(),


We have the contract address now:
0xb0830ef478a215ed393c20a0c97aa69869a0beea on bsc

Kailai-Wang · 2025-04-12T20:21:31Z

 	SubxtMetadataProvider<CustomConfig>,
 >;

+// TODO: temporary solution


Just curious: why is it temporary? I thought this was the solution 😂

@silva-fj ?

I was just thinking that on test networks for example the contract/mint addresses could be different so we may want to have a config for this

Kailai-Wang · 2025-04-12T20:49:28Z

+								for fill in trade_order.fills.unwrap() {
+									let fill_price: u128 = fill.price.parse().unwrap();
+									let fill_amount: u128 = fill.qty.parse().unwrap();
+									to_amount += fill_price * fill_amount;


Just to double-check that it's what we want - to_amount is the amount of BNBs to pay out? I just don't know if fill_price * fill_amount get it right. Like should it multiple it by fill_price?

Did it take decimal into consideration?

So if it's 0.01 BNB, to_amount will be (0.01 * 10^18), right?

These values are decimals i'll change it

Binance amount received will be multiplied by 10^8 because native BNB has a smalles unit Jager

That's a good catch - i wasn't sure about it. Thanks.

We actually need decimals in pumpx-api

It just has to match the binance api (what fill_price and fill_amount stand for)

Maybe you could write a comment naming an example for it - so that everyone that reads the code knows the intention at least

Kailai-Wang · 2025-04-12T21:17:31Z

+							},
+						},
+						// amount received from binance should be used...
+						amount_in: to_amount.to_string(),


Here we need to consider decimal, from previous example, backend expects 0.01 here, not 0.01 * (10^18)

Conversion to bnb unit (Jager) is done later. I expect current impl will result in 0.01 not 0.01 * 10^8

Kailai-Wang · 2025-04-12T22:32:39Z

+							})?;
+
+						match trade_order.status {
+							BinanceOrderStatus::FILLED => {


So it means it's fully "filled", right? No partial trade could happen

Now I assume we will get FILLED status with all fills (100% completion)

PARTIALLY_FILLED, FILLED,

PARTIALLY_FILLED status is ignored and we poll untill it's FILLED

I see - will we reach it eventually? Like can it be an endless loop?

Kailai-Wang

Let's merge it and I'll raise another PR to address the binance-api problem

silva-fj added 4 commits April 10, 2025 23:33

feat(binance): add wallet API functionality

489bc9d

feat(cross-chain): integrate Binance API dependency in the cross-chai…

dec6936

…n executor

feat(cross-chain): integrate BinanceApi in executor

debd3bb

feat(cross-chain): add initial Binance integration

213ee4d

Implement initial Binance API integration in the cross-chain executor

silva-fj requested review from Kailai-Wang and kziemianek April 11, 2025 00:37

silva-fj and others added 22 commits April 11, 2025 02:44

Merge branch 'dev' into p-1395-intent-processing-cross-chain-swap

007cb0e

Merge branch 'dev' into p-1395-intent-processing-cross-chain-swap

ab7b623

cross-order should only be all for cross chain swaps

abb38fa

feat(solana): implement RemoteSigner for transactions

2699d7b

Add RemoteSigner implementation that connects to the pumpx signer service for securely signing Solana transactions.

refactor(solana): inject runtime Handle to RemoteSigner

23debe3

Update RemoteSigner implementation to receive a tokio runtime Handle through constructor rather than retrieving it internally.

feat(solana): create independent module for SDK

0daaf5a

Extract Solana functionality into a dedicated module

fixing solana exports

10c5637

refactoring solana client, injecting it to the cross chain intent

ec57d99

executor

feat(solana): add SPL token mapping for cross-chain swaps

0dd4907

feat(cross-chain): implement Solana token transfers

bdf14fa

Merge branch 'dev' into p-1395-intent-processing-cross-chain-swap

ce009c4

Merge remote-tracking branch 'origin/dev' into p-1395-intent-processi…

8a560c7

…ng-cross-chain-swap

fixing fmt issue

7db5210

initial setup accounting contract call

d8e9d99

fixing fmt issue

1163176

adding more TODO's

1e22eff

determine cross chain payout address

7e1b156

taplo fmt

e4d47c9

Merge branch 'dev' into p-1395-intent-processing-cross-chain-swap

bc336ae

kziemianek force-pushed the p-1395-intent-processing-cross-chain-swap branch from 4625636 to bc336ae Compare April 12, 2025 07:23

kziemianek added 5 commits April 12, 2025 09:31

taplo fmt

a8d7641

remove address

5f36ac7

create pumpx market order

f8b0b95

calculate binance traded amount

739686e

add debug info

9beea18

kziemianek marked this pull request as ready for review April 12, 2025 09:29

kziemianek requested a review from a team April 12, 2025 09:29

kziemianek changed the title ~~Implement cross chain swaps (WIP)~~ Implement cross chain swaps Apr 12, 2025

Kailai-Wang requested changes Apr 12, 2025

View reviewed changes

Kailai-Wang reviewed Apr 12, 2025

View reviewed changes

Kailai-Wang and others added 8 commits April 12, 2025 22:36

fix clippy

82feb91

Merge branch 'dev' into p-1395-intent-processing-cross-chain-swap

8161663

use new api

3adaf1c

to_address

9ec55a0

binance fills with decimals

2d35896

binance bnb amount received to bnb jagers

39b82a1

Merge branch 'dev' into p-1395-intent-processing-cross-chain-swap

9f8a4d8

add contract adress

e4a5991

Kailai-Wang approved these changes Apr 13, 2025

View reviewed changes

Kailai-Wang merged commit 857d975 into dev Apr 13, 2025
21 checks passed

Kailai-Wang deleted the p-1395-intent-processing-cross-chain-swap branch April 13, 2025 10:28

Conversation

silva-fj commented Apr 11, 2025 • edited by kziemianek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear Bot commented Apr 11, 2025

Uh oh!

Kailai-Wang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kziemianek Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kziemianek Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kailai-Wang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

silva-fj commented Apr 11, 2025 •

edited by kziemianek

Loading

kziemianek Apr 13, 2025 •

edited

Loading

kziemianek Apr 13, 2025 •

edited

Loading