Add pumpx_signLimitOrder

[kziemianek]

Adds a rpc methods for signing arbitrary bytes.

[linear]

P-1450 Add `omni-executor` rpc method

[Kailai-Wang]

Thanks!

Would you update apifox once it's merged?

[Kailai-Wang]

Thank you

Shall we make a per task fn (like expected_auth_token_type() and add it as parameter to verify_auth) as it should be verified in most RPC methods?

[BillyWooo]

is it possible to reuse and keep alignment with other rpc calls?
Something like:

let wrapper: NativeTaskWrapper<NativeTask> = params.into();

if wrapper.task.require_auth() && verify_auth(ctx.clone(), &wrapper).await.is_err() {
return Err(ErrorCode::ServerError(AUTH_VERIFICATION_FAILED_CODE).into());
}

[kziemianek]

is it possible to reuse and keep alignment with other rpc calls? Something like:

let wrapper: NativeTaskWrapper<NativeTask> = params.into();

if wrapper.task.require_auth() && verify_auth(ctx.clone(), &wrapper).await.is_err() {
return Err(ErrorCode::ServerError(AUTH_VERIFICATION_FAILED_CODE).into());
}

Yes but that would require some time for rework.

[BillyWooo]

Just copy/paste and change fields? can it help?
Like:

impl From<RequestJwtParams> for NativeTaskWrapper<NativeTask> {
	fn from(p: RequestJwtParams) -> Self {
		Self {
			task: NativeTask::PumpxRequestJwt(
				Identity::from_web2_account(p.user_email.as_str(), Web2IdentityType::Email),
				p.invite_code,
				p.google_code,
				p.language,
			),
			nonce: None,
			auth: Some(OmniAuth::Email(p.email_code)),
		}
	}
}

[kziemianek]

Nope, simple copy paste doesn't help in this case 😂

[kziemianek]

The main problem is that verify_auth function derives omni_account from sender Identity.
In case of JWT type: access sub field already contains omni_account.

[kziemianek]

Thanks!

Would you update apifox once it's merged?

apifox should be already up to date 🙃