Implement swap intent for pumpx #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SubmitSwapOrderParams structures
silva-fj
changed the title
…pumpx Signed-off-by: Francisco Silva <franjs.francisco@gmail.com>
Add intent_id field to SubmitSwapOrderParams and pass it through the intent execution flow to replace the hardcoded 0 value in the intent_completed call and RequestIntent task creation.
silva-fj
changed the title
silva-fj
changed the title
Kailai-Wang
reviewed
Apr 10, 2025
tee-worker/omni-executor/intent/executors/cross-chain/src/lib.rs
Outdated
Show resolved
Hide resolved
| execution_result, | ||
| ); | ||
| ctx.transaction_signer.sign(intent_executed_call).await | ||
| let tx = ctx.transaction_signer.sign(intent_executed_call).await; | ||
| if rpc_client.submit_tx(&tx).await.is_err() { |
There was a problem hiding this comment.
It doesn't wait for any finalisation, does it? (We don't want to wait for it)
There was a problem hiding this comment.
No it does not wait, when we want to wait we use submit_and_watch_tx_until
| @@ -60,16 +77,19 @@ pub type ParentchainTxSigner = TxSigner< | |||
| SubxtMetadataProvider<CustomConfig>, | |||
| >; | |||
|
|
|||
| // TODO: should we rename this to something like MultiChainIntentExecutor? | |||
There was a problem hiding this comment.
Good idea - but probably in separate PR
tee-worker/omni-executor/intent/executors/cross-chain/src/lib.rs
Outdated
Show resolved
Hide resolved
…-chain-swap-intent-for-pumpx
kziemianek
approved these changes
Apr 10, 2025
| @@ -29,7 +29,7 @@ pub trait IntentExecutor: Send { | |||
| account_id: &AccountId, | |||
| intent_id: IntentId, | |||
| intent: Intent, | |||
| ) -> Result<(), ()>; | |||
| ) -> Result<Option<Vec<u8>>, ()>; | |||
There was a problem hiding this comment.
Do you mean like a trait object?
Kailai-Wang
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a draft implementation of the swap intent processing for pumpx so we can start testing.
Important notes: