-
Notifications
You must be signed in to change notification settings - Fork 18
P 1419 implement pumpx_addWallet rpc #3341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… p-1419-implement-pumpxaddwallet
tee-worker/omni-executor/rpc-server/src/methods/pumpx/add_wallet.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just the RPC response needs adjustment
tee-worker/omni-executor/rpc-server/src/methods/pumpx/add_wallet.rs
Outdated
Show resolved
Hide resolved
Btw a small thing: could you rename the PR title to be more readable? : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, The implementation looks good,
However the response is empty, are we looking to provide a 200 result without any data?
Add
addWallet
rpc call.