Skip to content

P 1419 implement pumpx_addWallet rpc #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 9, 2025
Merged

Conversation

BillyWooo
Copy link
Collaborator

Add addWallet rpc call.

@BillyWooo BillyWooo requested review from Kailai-Wang, silva-fj and a team April 7, 2025 12:30
@BillyWooo BillyWooo self-assigned this Apr 7, 2025
Copy link

linear bot commented Apr 7, 2025

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just the RPC response needs adjustment

@Kailai-Wang
Copy link
Collaborator

Btw a small thing: could you rename the PR title to be more readable? : )

@BillyWooo BillyWooo changed the title P 1419 implement pumpxaddwallet P 1419 implement pumpx_addWallet rpc Apr 9, 2025
Copy link
Member

@felixfaisal felixfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, The implementation looks good,
However the response is empty, are we looking to provide a 200 result without any data?

@Kailai-Wang Kailai-Wang merged commit 2358d4c into dev Apr 9, 2025
21 checks passed
@Kailai-Wang Kailai-Wang deleted the p-1419-implement-pumpxaddwallet branch April 9, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants