Skip to content

Add previous/next page links at bottom of docs pages #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Apr 7, 2021

Fixes #237

image

@aomarks aomarks requested review from sorvell and arthurevans April 7, 2021 18:31
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr282-6707fbd---lit-dev-5ftespv5na-uc.a.run.app/
https://pr282-7e34d25---lit-dev-5ftespv5na-uc.a.run.app/
https://pr282-ff3e020---lit-dev-5ftespv5na-uc.a.run.app/

Copy link
Member

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a little weird to have the Prev/Next on pages that also have a See also or Next Steps at the bottom. Sometimes the Prev/Next link is duplicated there. Do we care?

Here's a list:

  • What is Lit: Next Steps refers to Getting Started which is the next link
  • Rendering: See Also refers to Reactive Properties which is the next link

@arthurevans
Copy link
Contributor

I think in the case of What is Lit, those are sort of mini-calls to action, and I'd be inclined to keep them all. The Next at the bottom is sort of a default action. For the See also sections, I think we can delete the duplicate link.

@aomarks
Copy link
Member Author

aomarks commented Apr 7, 2021

I think in the case of What is Lit, those are sort of mini-calls to action, and I'd be inclined to keep them all. The Next at the bottom is sort of a default action. For the See also sections, I think we can delete the duplicate link.

Ok, I only removed the "Reactive properties" link in rendering, but didn't change anything else.

@aomarks aomarks merged commit 859d309 into master Apr 7, 2021
@aomarks aomarks deleted the next-prev branch April 7, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show next/prev buttons in docs
3 participants