-
Notifications
You must be signed in to change notification settings - Fork 206
New playground design #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A live preview of this PR will be available at the URL(s) below. https://pr226-a5cae3c---lit-dev-5ftespv5na-uc.a.run.app/playground/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I kind of like the vertical split better. Maybe we could add a toggle on the toolbar?
I don't know about this. I basically prefer everything about the current playground:
If this goes in I'd at least like a way to preserve the current version for a comparison. Has Ocupop seen the current styling? |
The old versions will be accessible at older PR links, is that good enough?
Do you mean this PR, or the original version? They've seen the original version, but not this PR. |
I made this change, and explained it in the PR description. I think it works better on narrower screens when you have the examples drawer open -- my suggestion above was to have a toggle or a media query. |
This is now responsive: side-by-side on wider screens, above-below on narrower screens. |
Don't disagree with these points. Going to land this with the current styles that are fairly close to the mocks, but will iterate in a followup sometime this week. |
Fixes #225