Update developement docs #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested changes
Feb 23, 2021
|
|
||
| ### Using Linting plugins | ||
|
|
||
| Integrating linting into your IDE workflow can help catch errors as early as possible, right when you're typing out your code. The following ESLint plugin can be added to check for some common issues in Lit templates: |
There was a problem hiding this comment.
It's odd that we recommend two Lit-specific IDE plugins, above and in this section. Seems less confusing to only talk about one, or else talk about them in the same section, at least. Since we call out the TypeScript plugin, maybe it would make sense to call this an ESLint plugin in that same section? And maybe move the linting section above the IDE plugin section (so that linting is introduced first?)
There was a problem hiding this comment.
Re-organized sections as recommended.
|
|
||
| * [https://github.com/43081j/eslint-plugin-lit](https://github.com/43081j/eslint-plugin-lit) | ||
|
|
||
| ## Setting up formatting { #formatting } |
There was a problem hiding this comment.
I'd personally nix this section; there's nothing Lit-specific about it.
There was a problem hiding this comment.
Neither does the TS section. Re-org'd a bit.
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@web/dev-server