-
Notifications
You must be signed in to change notification settings - Fork 205
Update code reuse overview. Fixes #83. #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A live preview of this PR will be available at the URL(s) below. https://pr144-4550b82---lit-dev-bvxw3ycs6q-uw.a.run.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding cross-references or next steps or something from this page to the following three on directives, controllers and mixins.
Also, #134 (comment) duplicates some of this discussion; seems like that should be deduped and moved to one spot with a cross-reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty minor comments. Happy to merge and make issues for anything outstanding.
* Composition | ||
* Directives | ||
* Reactive controllers | ||
* Class mixins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest linking these to their respective sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked from the discussion below, instead. From here, it would be unclear to me whether I was linking down on the page or to a separate page.
|
||
_Class mixins_ let you write reusable partial component definitions and "mix them in" to a component's inheritance chain. | ||
|
||
Both mixins and reactive controllers let you group code related to a feature into a reusable unit. However, they're applied in different ways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This discussion feels out of place in the overview. I feel like there should be one section for Controllers and mixins
that explains both and when to use them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a header for this, hopefully that helps.
Co-authored-by: Steve Orvell <sorvell@google.com> Co-authored-by: Kevin Schaaf <kschaaf@google.com>
…code-reuse-overview
No description provided.