Skip to content

Update code reuse overview. Fixes #83. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Conversation

arthurevans
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build usually takes around 7 minutes, and will 404 until finished.

https://pr144-4550b82---lit-dev-bvxw3ycs6q-uw.a.run.app/
https://pr144-47d183b---lit-dev-bvxw3ycs6q-uw.a.run.app/
https://pr144-b916a9b---lit-dev-bvxw3ycs6q-uw.a.run.app/
https://pr144-06aecce---lit-dev-bvxw3ycs6q-uw.a.run.app/

@nicolejadeyee nicolejadeyee added this to the Website complete milestone Feb 10, 2021
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding cross-references or next steps or something from this page to the following three on directives, controllers and mixins.

Also, #134 (comment) duplicates some of this discussion; seems like that should be deduped and moved to one spot with a cross-reference?

Copy link
Member

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty minor comments. Happy to merge and make issues for anything outstanding.

* Composition
* Directives
* Reactive controllers
* Class mixins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest linking these to their respective sections

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked from the discussion below, instead. From here, it would be unclear to me whether I was linking down on the page or to a separate page.


_Class mixins_ let you write reusable partial component definitions and "mix them in" to a component's inheritance chain.

Both mixins and reactive controllers let you group code related to a feature into a reusable unit. However, they're applied in different ways.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This discussion feels out of place in the overview. I feel like there should be one section for Controllers and mixins that explains both and when to use them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a header for this, hopefully that helps.

Arthur Evans and others added 2 commits February 26, 2021 18:30
Co-authored-by: Steve Orvell <sorvell@google.com>
Co-authored-by: Kevin Schaaf <kschaaf@google.com>
@arthurevans arthurevans merged commit 914cf98 into master Mar 1, 2021
@arthurevans arthurevans deleted the code-reuse-overview branch March 1, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants