- 
                Notifications
    
You must be signed in to change notification settings  - Fork 319
 
Run benchmarks on GitHub actions. #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    We need this to make tachometer happy. Tachometer should be more flexible though, and then we can flatten this back out.
This reduces variance quite a bit.
Add js-framework-benchmarks for lit-html
Add LitElement and Polymer 3 versions of the Shack benchmark
4a0761f    to
    9cccef8      
    Compare
  
    cb14778    to
    dc616fb      
    Compare
  
    dc616fb    to
    23d29d5      
    Compare
  
    
          📊 Tachometer Benchmark ResultsSummarycallback
 Resultsshack
 
  | 
    
bf7d6b5    to
    993343b      
    Compare
  
    | 
           I'm going to merge this into   | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR updates this repo to run the benchmarks using GitHub actions.
I originally tried the same approach as lit/lit#1967 but found that the import specifiers were being mapped to paths that didn't exist, which caused the benchmarks to time out. I'm not entirely sure why this didn't work, but I suspect it was due to the way that tachometer expects the repo it will benchmark is set up. Particularly, tachometer seems to expect that the package it runs within stays the same and that different versions of the dependencies are what should be effectively benchmarked.
I've updated this repo's benchmark workflow to check out the benchmark package separately so that it can be the root package with lit-element as its dependencies.I've merged the LitElement benchmarks from https://github.com/Polymer/benchmarks into this repo under
benchmarksand made that folder a private NPM package, which seems to be tachometer's preferred setup.