Skip to content

Conversation

@bicknellr
Copy link
Member

@bicknellr bicknellr commented Jul 23, 2021

This PR updates this repo to run the benchmarks using GitHub actions.

I originally tried the same approach as lit/lit#1967 but found that the import specifiers were being mapped to paths that didn't exist, which caused the benchmarks to time out. I'm not entirely sure why this didn't work, but I suspect it was due to the way that tachometer expects the repo it will benchmark is set up. Particularly, tachometer seems to expect that the package it runs within stays the same and that different versions of the dependencies are what should be effectively benchmarked.

I've updated this repo's benchmark workflow to check out the benchmark package separately so that it can be the root package with lit-element as its dependencies.

I've merged the LitElement benchmarks from https://github.com/Polymer/benchmarks into this repo under benchmarks and made that folder a private NPM package, which seems to be tachometer's preferred setup.

aomarks and others added 30 commits April 15, 2019 16:36
We need this to make tachometer happy. Tachometer should be more
flexible though, and then we can flatten this back out.
Add js-framework-benchmarks for lit-html
Add LitElement and Polymer 3 versions of the Shack benchmark
@bicknellr bicknellr force-pushed the gh-actions-benchmarks branch from 4a0761f to 9cccef8 Compare July 23, 2021 20:56
@bicknellr bicknellr force-pushed the gh-actions-benchmarks branch 2 times, most recently from cb14778 to dc616fb Compare July 23, 2021 21:10
@bicknellr bicknellr force-pushed the gh-actions-benchmarks branch from dc616fb to 23d29d5 Compare July 23, 2021 21:12
@github-actions
Copy link

github-actions bot commented Jul 23, 2021

📊 Tachometer Benchmark Results

Summary

callback

  • shack: unsure 🔍 -3% - +1% (-0.71ms - +0.20ms)
    this-change vs master

Results

shack
VersionAvg timevs this-changevs mastervs previous-2.x-release
this-change23.03ms - 23.55ms-unsure 🔍
-3% - +1%
-0.71ms - +0.20ms
unsure 🔍
-2% - +2%
-0.55ms - +0.36ms
master23.17ms - 23.91msunsure 🔍
-1% - +3%
-0.20ms - +0.71ms
-unsure 🔍
-2% - +3%
-0.37ms - +0.68ms
previous-2.x-release23.01ms - 23.76msunsure 🔍
-2% - +2%
-0.36ms - +0.55ms
unsure 🔍
-3% - +2%
-0.68ms - +0.37ms
-

tachometer-reporter-action v2 for Benchmarks

@bicknellr bicknellr force-pushed the gh-actions-benchmarks branch 4 times, most recently from bf7d6b5 to 993343b Compare July 23, 2021 22:16
@bicknellr bicknellr marked this pull request as ready for review July 23, 2021 22:27
@bicknellr bicknellr requested a review from justinfagnani as a code owner July 23, 2021 22:27
@bicknellr bicknellr requested a review from aomarks July 23, 2021 22:27
@bicknellr
Copy link
Member Author

I'm going to merge this into gh-actions and continue working from there.

@bicknellr bicknellr merged commit 8d9bd31 into gh-actions Jul 26, 2021
@bicknellr bicknellr deleted the gh-actions-benchmarks branch July 26, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants