Make Vesta URL config explicit and add optional logger config #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vesta recently changed their URL configs for the sandbox, so the JSON and JSONP URLs have different domains. Since there are now 4 possible URL combos, its easier to just allow explicitly setting the URLs instead of having the underlying system join paths.
A typical setup might look something like this now:
I setup all the URLs based on the previous defaults, so if Vesta hasn't changed your URLs this should just work for you.
This PR also adds the option to pass a logger down to HTTParty. Doing
config.logger = Rails.logger
will set the HTTParty logger when making requests and give nice request/response logging.