Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore error when drop #209

Merged
merged 1 commit into from
Aug 24, 2020
Merged

fix: ignore error when drop #209

merged 1 commit into from
Aug 24, 2020

Conversation

lisphilar
Copy link
Owner

Related issues

This is related to #202, #203 and #206

@lisphilar lisphilar added bug Something isn't working enhancement New feature or request labels Aug 24, 2020
@lisphilar lisphilar added this to the Release CovsirPhy v2.8.0 milestone Aug 24, 2020
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 24, 2020

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.69 1.69 0.00
Method Length 66.53 66.59 0.06 🔴
Quality 8.32 8.32 0.00
Other metrics Before After Change
Lines 824 825 1
Changed files Quality Before Quality After Quality Change
covsirphy/analysis/scenario.py 8.32 8.32 0.00

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
covsirphy/analysis/scenario.py Scenario.describe 5 229.84 5.41 Split out functionality
covsirphy/analysis/scenario.py Scenario.param_history 8 140.78 6.17 Split out functionality
covsirphy/analysis/scenario.py Scenario._track_param 2 169.90 6.35 Split out functionality
covsirphy/analysis/scenario.py Scenario._param_history 4 149.91 6.43 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@lisphilar lisphilar merged commit 0b6e93b into master Aug 24, 2020
@lisphilar lisphilar deleted the issue203_fu branch August 24, 2020 03:53
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: ignore error whhen drop

Powered by Pull Assistant. Last update c627904 ... c627904. Read the comment docs.

@lisphilar lisphilar changed the title fix: ignore error whhen drop fix: ignore error when drop Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant