Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use type hints in APIs users will call: downloading, show type hint in documentation #1285

Merged
merged 4 commits into from
Oct 14, 2022

Conversation

lisphilar
Copy link
Owner

Related issues

#1258

What was changed

  • use type hints in APIs users will call: downloading
  • show type hints in documentation using sphinx_autodoc_typehints and sphinx.ext.intersphinx

@lisphilar lisphilar added the documentation Improvements or additions to documentation label Oct 14, 2022
@lisphilar lisphilar added this to the Release v3.0.0 milestone Oct 14, 2022
@lisphilar lisphilar changed the title Issue1258 downloading api use type hints in APIs users will call: downloading Oct 14, 2022
@lisphilar lisphilar merged commit 16abaec into main Oct 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue1258_downloading_api branch October 14, 2022 17:39
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 14, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.83%.

Quality metrics Before After Change
Complexity 1.40 ⭐ 1.36 ⭐ -0.04 👍
Method Length 85.40 🙂 92.60 🙂 7.20 👎
Working memory 5.45 ⭐ 5.23 ⭐ -0.22 👍
Quality 76.44% 75.61% -0.83% 👎
Other metrics Before After Change
Lines 190 200 10
Changed files Quality Before Quality After Quality Change
covsirphy/downloading/downloader.py 68.01% 🙂 67.81% 🙂 -0.20% 👎
docs/conf.py 84.86% ⭐ 82.10% ⭐ -2.76% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
covsirphy/downloading/downloader.py DataDownloader.layer 4 ⭐ 166 😞 9 🙂 59.39% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lisphilar lisphilar changed the title use type hints in APIs users will call: downloading use type hints in APIs users will call: downloading, show type hint in documentation Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant