Issue1223

[lisphilar]

Related issues

#1223

What was changed

Close #1223

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.93%.

Quality metrics	Before	After	Change
Complexity	0.42 ⭐	0.71 ⭐	0.29 👎
Method Length	74.68 🙂	75.73 🙂	1.05 👎
Working memory	5.34 ⭐	5.41 ⭐	0.07 👎
Quality	78.48% ⭐	77.55% ⭐	-0.93% 👎

Other metrics	Before	After	Change
Lines	262	271	9

Changed files	Quality Before	Quality After	Quality Change
covsirphy/downloading/downloader.py	66.61% 🙂	63.71% 🙂	-2.90% 👎
tests/test_downloading/test_downloading.py	86.59% ⭐	86.36% ⭐	-0.23% 👎
tests/test_engineering/test_engineer.py	73.89% 🙂	73.73% 🙂	-0.16% 👎
tests/test_science/test_ml.py	84.08% ⭐	83.83% ⭐	-0.25% 👎
tests/test_visualization/test_visualize.py	94.52% ⭐	94.54% ⭐	0.02% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
covsirphy/downloading/downloader.py	DataDownloader.layer	6 ⭐	193 😞	9 🙂	55.07% 🙂	Try splitting into smaller methods
tests/test_engineering/test_engineer.py	TestDataEngineer.test_operations	0 ⭐	246 ⛔	6 ⭐	64.57% 🙂	Try splitting into smaller methods
tests/test_engineering/test_engineer.py	TestDataEngineer.test_from_sample_data	0 ⭐	151 😞	6 ⭐	71.90% 🙂	Try splitting into smaller methods
tests/test_science/test_ml.py	TestMLEngineer.test_forecast	0 ⭐	125 😞	6 ⭐	74.85% 🙂	Try splitting into smaller methods
tests/test_engineering/test_engineer.py	TestDataEngineer.test_with_actual_data	0 ⭐	143 😞	5 ⭐	75.32% ⭐	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #1229 (0d2178c) into master (58e279b) will decrease coverage by 1.65%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   88.73%   87.08%   -1.66%     
==========================================
  Files          43       43              
  Lines        2823     2826       +3     
==========================================
- Hits         2505     2461      -44     
- Misses        318      365      +47     

Impacted Files	Coverage Δ
covsirphy/downloading/downloader.py	97.22% <75.00%> (-2.78%)	⬇️
covsirphy/__version__.py	100.00% <100.00%> (ø)
covsirphy/downloading/_db_google.py	25.80% <0.00%> (-72.59%)	⬇️
covsirphy/util/term.py	80.98% <0.00%> (-0.62%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.