Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect headers and method from request input parameter #12

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: respect headers and method from request input parameter #12

merged 1 commit into from
Jul 26, 2024

Conversation

orionmiz
Copy link
Contributor

@orionmiz orionmiz commented Dec 19, 2023 •
edited
Loading

FetchRequest is expected to be constucted with only single Request object as the first parameter of the constructor.

However, FetchRequest only extracts url from Request without headers and method for now.

This PR includes them as fallback value for options
(the second parameter, RequestInit object) also so that can construct FetchRequest properly.

@orionmiz orionmiz changed the title fix: respect header and method from input parameter fix: respect headers and method from input parameter Dec 19, 2023
@orionmiz orionmiz changed the title fix: respect headers and method from input parameter fix: respect headers and method from request input parameter Dec 19, 2023
@orionmiz
Copy link
Contributor Author

@surunzi Could you review it, please?

@surunzi surunzi merged commit a6abf1b into liriliri:master Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow110914 Shadow110914 Shadow110914 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orionmiz @Shadow110914 @surunzi