Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/warning if download count is low #305

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

lirantal
Copy link
Owner

@lirantal lirantal commented Mar 4, 2024

Description

Adding a new download counts threshold which is 10k downloads per month and if below it then we show a warning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lirantal lirantal self-assigned this Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (6a3f090) to head (89275d9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          14       14           
  Lines         398      398           
  Branches       61       61           
=======================================
  Hits          384      384           
  Misses         12       12           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lirantal lirantal merged commit 81d1d85 into main Mar 4, 2024
11 checks passed
@lirantal lirantal deleted the fix/warning-if-download-count-is-low branch March 4, 2024 06:33
Copy link

github-actions bot commented Mar 4, 2024

🎉 This PR is included in version 3.4.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant