fix: author marshall reported date diff for very old package releases #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a package had a below 30 days time diff between author first relases to the version being grabbed, but was 8 years old on the registry then the alert would still show up. this was fixed with a 45 days window from the released version and up to the current date as a more sane check
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 14 14
Lines 398 398
Branches 61 61
=======================================
Hits 384 384
Misses 12 12
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 3.4.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a package had a below 30 days time diff between author first relases to the version being grabbed, but was 8 years old on the registry then the alert would still show up.
this was fixed with a 45 days window from the released version and up to the current date as a more sane check
Description
Types of changes
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: