Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled postinstall Prompt In NPM v7 #196

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

OmriBarZik
Copy link
Contributor

Description

In npm v7 the postinstall script longer accepts user input and does not show any messages to the user.
this make npq fails at installation in npm v7. to solve this I disabled the prompt in npm v7

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Fixes #185

Motivation and Context

had a problem with installing npq in npm v7 and wanted to solve it.

How Has This Been Tested?

Added automatic tests to the project.
run the project on windows and ubuntu machines with both npm v6, npm v7, and yarn

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #196 (59e0f75) into master (d36bce0) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   96.98%   97.06%   +0.08%     
==========================================
  Files          10       10              
  Lines         265      273       +8     
  Branches       46       49       +3     
==========================================
+ Hits          257      265       +8     
  Misses          6        6              
  Partials        2        2              
Impacted Files Coverage Δ
scripts/postinstall.js 86.20% <100.00%> (+1.59%) ⬆️
scripts/scriptHelpers.js 94.73% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36bce0...59e0f75. Read the comment docs.

@lirantal lirantal merged commit e1cb2aa into lirantal:master Jul 15, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.0.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails with npm v7
2 participants