Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audit): a test can support device type flags #33

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

samarpanda
Copy link
Contributor

@samarpanda samarpanda commented Oct 26, 2019

Feature: Website test can support device type flags

Types of changes

  • New feature (non-breaking change which adds functionality)

Related Issue

#23

Motivation and Context

This feature enables mobile and desktop vulnerability detection associated to a given URL

How Has This Been Tested?

Added unit test for all changes and ensured all previous test are passing.
Picked one site which uses different stacks for mobile and desktop. Accordingly i got different vulnerabilities for mobile and desktop.

Screenshots (if appropriate):

Vulnerable test 01 with mobile, desktop & none flags

Vulnerable test 02

Checklist:

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lirantal lirantal self-requested a review October 26, 2019 09:03
@lirantal lirantal changed the title Test can support device type flags feat(audit): a test can support device type flags Oct 26, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@85792eb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   93.33%           
=========================================
  Files             ?        5           
  Lines             ?      120           
  Branches          ?       23           
=========================================
  Hits              ?      112           
  Misses            ?        8           
  Partials          ?        0
Impacted Files Coverage Δ
src/Utils.js 100% <100%> (ø)
src/Audit.js 93.75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85792eb...93a3b47. Read the comment docs.

@samarpanda samarpanda changed the title feat(audit): a test can support device type flags feat(audit): test can support device type flags Oct 28, 2019
@samarpanda samarpanda changed the title feat(audit): test can support device type flags feat(audit): a test can support device type flags Oct 28, 2019
@samarpanda
Copy link
Contributor Author

PR is complete @lirantal. Please take a look.

@samarpanda samarpanda removed their assignment Oct 28, 2019
Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @samarpanda 👍

@lirantal lirantal merged commit 82ade9b into lirantal:master Oct 28, 2019
@github-actions
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants