Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jslib): print library information if --js-lib flag is passed #21

Merged
merged 2 commits into from
Oct 19, 2019
Merged

feat(jslib): print library information if --js-lib flag is passed #21

merged 2 commits into from
Oct 19, 2019

Conversation

Cardoso222
Copy link
Contributor

Description

Show library information when --js-lib flag is passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

refs #6

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

js-library

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@codecov-io
Copy link

codecov-io commented Oct 10, 2019 •
edited
Loading

Codecov Report

Merging #21 into master will increase coverage by 0.92%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage    91.3%   92.23%   +0.92%     
==========================================
  Files           5        5              
  Lines          92      103      +11     
  Branches       14       17       +3     
==========================================
+ Hits           84       95      +11     
  Misses          8        8
Impacted Files Coverage Δ
src/RenderConsole.js 91.11% <100%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9824c7...ac7f71d. Read the comment docs.

@lirantal lirantal self-requested a review October 19, 2019 10:04
@lirantal lirantal added the enhancement New feature or request label Oct 19, 2019
@lirantal
Copy link
Owner

@Cardoso222 thanks for sending this.
Could you merge with latest changes from master? (no need to rebase if that is giving you issues since I'll anyway squash the commits when I merge this back).

@Cardoso222
Copy link
Contributor Author

Updated!

lirantal
lirantal approved these changes Oct 19, 2019
View reviewed changes
Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @Cardoso222, thank you ❤️👏

@lirantal lirantal merged commit 255c570 into lirantal:master Oct 19, 2019
@lirantal
Copy link
Owner

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lirantal
Copy link
Owner

@Cardoso222 do you want to follow this up with another PR that updates the README page with the optional --js-lib command line argument? like here: https://github.com/lirantal/is-website-vulnerable/blame/master/README.md#L39

This was referenced Oct 19, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirantal lirantal lirantal approved these changes

Assignees

@Cardoso222 Cardoso222

Labels
enhancement New feature or request hacktoberfest released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cardoso222 @codecov-io @lirantal