fix: do not default mount point for volumes #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
added
area/api
Callisto13
previously approved these changes
Dec 14, 2021
yitsushi
previously approved these changes
Dec 14, 2021
richardcase
dismissed stale reviews from yitsushi and Callisto13
via
07ce400
richardcase
force-pushed
the
47_require_mount_path
branch
from
ff4c518 to
07ce400
Compare
Taken of the kubebuilder default for the mount point of volumes, Previously it defaulted to `/` and so if there was more than 1 volume specified without mount points set there would be collision of mount points. It has been changed to a required field without a default to force users to specify it. Signed-off-by: Richard Case <richard@weave.works>
richardcase
force-pushed
the
47_require_mount_path
branch
from
07ce400 to
e8f5c8a
Compare
Callisto13
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Taken of the kubebuilder default for the mount point of volumes,
Previously it defaulted to
/and so if there was more than 1 volumespecified without mount points set there would be collision of mount
points. It has been changed to a required field without a default to
force users to specify it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #47
Special notes for your reviewer:
Checklist: