fix: failure domains reporting from microvmcluster #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
added
area/api
richardcase
force-pushed
the
fix_failure_domains
branch
from
3a46526 to
01de795
Compare
richardcase
changed the title
Callisto13
reviewed
Dec 14, 2021
Callisto13
reviewed
Dec 14, 2021
richardcase
force-pushed
the
fix_failure_domains
branch
from
01de795 to
231082b
Compare
Callisto13
previously approved these changes
Dec 14, 2021
yitsushi
previously approved these changes
Dec 14, 2021
richardcase
dismissed stale reviews from yitsushi and Callisto13
via
f62417c
richardcase
force-pushed
the
fix_failure_domains
branch
from
162960a to
f62417c
Compare
The API definitions for the MicrovmMachine was incorrectly specify **FailureDomain** which is a deprecated way to specify a failure domain. This has been removed and the code now looks for failure domain on the **Machine** instead as this is the correct way. Declarative placement has been introduced at the **MicrovmCluster** level with the ability to set a static list of host endpoints to use when creating microvms. This relies on the failure domain logic to assign a **Machine** to one of the host endpoints. Signed-off-by: Richard Case <richard@weave.works>
richardcase
force-pushed
the
fix_failure_domains
branch
from
f62417c to
8173945
Compare
Callisto13
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The API definitions for the MicrovmMachine was incorrectly spcified
FailureDomain which is a deprecated way to specify a failure domain.
This has been removed, and the code now looks for failure domain on the
Machine instead as this is the correct way.
Declarative placement has been introduced at the MicrovmCluster
level with the ability to set a static list of host endpoints to use
when creating microvms. This relies on the failure domain logic to
assign a Machine to one of the host endpoints.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #14
Special notes for your reviewer:
Checklist: