feat: added cluster and machine api definitions #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
added
area/api
richardcase
changed the title
richardcase
force-pushed
the
api_types
branch
from
6b2c0fa to
1af70e9
Compare
richardcase
changed the title
richardcase
force-pushed
the
api_types
branch
from
1af70e9 to
32f2019
Compare
richardcase
changed the title
richardcase
force-pushed
the
api_types
branch
from
32f2019 to
1014a50
Compare
The initial api definitions for the capi infrastructure implementations of cluster, machine and machinetemplate have been added. The type follow the capi requirements: *[cluster](https://cluster-api.sigs.k8s.io/developer/providers/cluster-infrastructure.html) *[machine](https://cluster-api.sigs.k8s.io/developer/providers/machine-infrastructure.html) The api types are based on a simplified version of the flintlock grpc api. In capi provider we will make some assumptions/defaults. Signed-off-by: Richard Case <richard@weave.works>
richardcase
force-pushed
the
api_types
branch
from
1014a50 to
2990f1d
Compare
yitsushi
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The initial api definitions for the capi infrastructure implementations of cluster, machine and machinetemplate have been added.
The types follow the capi requirements:
The api types are based on a simplified version of the flintlock grpc api. In this capi provider we will make some assumptions/defaults.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #10
Special notes for your reviewer:
The main parts for review are api/v1alpha1/*.go
There is a lot of auto-generated configuration from the go code that doesn't need to be reviewed.
Checklist: