Skip to content

scope.Cluster.ClusterName is never set #120

@Callisto13

Description

@Callisto13

A couple of times we log clusterScope.ClusterName() which returns the value of scope.Cluster.ClusterName, so the owning cluster object.

This is never set by CAPI

// This field is not set anywhere right now and apiserver is going to ignore it if set in create or update request.

and from what I can see neither do we.

So either we:

  • Actually meant to use scope.MmvCluster.Name here
  • or we need to set that somewhere so the logs aren't weird
  • or see if that value lives somewhere else on the MvmCluster object that we can use

Metadata

Metadata

Assignees

Labels

kind/bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions