Repository navigation
docs: add ADR for idempotent claims - #101
Merged
Merged
Conversation
phoban01
force-pushed
the
adr/idempotent-claims
branch
2 times, most recently
from
September 24, 2026 19:25
1cf3a24 to
a73aa00
Compare
Flesh out issue liquidmetal-dev#98 into an architecture decision record: a client-chosen request_id on ClaimVMRequest, stored on the lease row, so a retried claim returns the lease the first attempt created instead of a second VM.
phoban01
force-pushed
the
adr/idempotent-claims
branch
from
September 24, 2026 19:46
a73aa00 to
fee9575
Compare
31 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fleshes out #98 into an architecture decision record at
docs/adr/2026-09-24-idempotent-claims.md.The ADR proposes:
request_idonClaimVMRequest(named per AIP-155), echoed onLeaseRecord.ClaimVMwith the samerequest_idreturns the lease the first attempt created, for as long as that lease exists. No separate key table or sweep.UNIQUEindex onleases.request_idresolves concurrent duplicates; the loser returns its VM toAVAILABLEand replays the winner's lease.--request-idflag onpoolmgrctl lease claim, perAGENTS.md.PRAGMA user_version), sinceCREATE TABLE IF NOT EXISTScannot add a column to an existing database.The orphaned-VM case on the reconciler's own
CreateMicroVMcall to flintlock is called out as related but out of scope, since flintlock's API has no idempotency field to use.Docs only. No code changes.
Refs #98