Merged
Conversation
CatarinaGamboa
approved these changes
Jan 10, 2026
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
couple comments but should be good to go
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; | ||
|
|
||
| public class PathUtils { |
Collaborator
There was a problem hiding this comment.
lets explain why we need this class, is mostly for handling paths for different OS and find the directories where liquidjava should be used right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts some parts of #26 by using verification paths from file events rather than the workspace root, to allow for more flexible project structures without requiring a
src/main/javadirectory for the verification to be performed. It also centralizes path handling logic intoPathUtils.