Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MongoOSS Extension :: Consume core and pro from GPM #439

Merged
merged 4 commits into from
Sep 18, 2023
Merged

MongoOSS Extension :: Consume core and pro from GPM #439

merged 4 commits into from
Sep 18, 2023

Conversation

sayaliM0412
Copy link

  • Consume CORE and PRO packages from GPM

vitaliimak
vitaliimak reviewed Sep 15, 2023
View reviewed changes
.github/workflows/test.yml Outdated
},
{
"id": "liquibase-super-pom",
"url": "https://maven.pkg.github.com/liquibase/liquibase-super-pom",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project has been renamed. https://github.com/liquibase/liquibase-parent-pom

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thank you. This will be taken care of in Jandro's PR. I have removed the super-pom from this PR

@vitaliimak
Copy link

Hi @sayaliM0412
Need to verify that dependabot has enough rights to perform writing settings.xml to the path: /home/runner/.m2/settings.xml or do any other stuff related to the maven-settings-xml-action.
Look at the liqiubase-commercial-mongodb repository. Dependabot PRs failed, and human PRs were successful after a similar update.

@jandroav
Copy link

we can remove all references to GPM regarding liquibase-parent-pom because it is now in Maven Central instead of GPM

@sayaliM0412
Copy link
Author

Hi @sayaliM0412 Need to verify that dependabot has enough rights to perform writing settings.xml to the path: /home/runner/.m2/settings.xml or do any other stuff related to the maven-settings-xml-action. Look at the liqiubase-commercial-mongodb repository. Dependabot PRs failed, and human PRs were successful after a similar update.

After adding the LIQUIBOT_PAT to dependabot we can see liquibase-commercial-mongodb dependabot PR is successful

@sayaliM0412 sayaliM0412 merged commit 029bef9 into main Sep 18, 2023
16 checks passed
@sayaliM0412 sayaliM0412 deleted the DAT-15809 branch September 18, 2023 12:59
@sayaliM0412 sayaliM0412 changed the title DAT-15809 MongoOSS Extension :: Consume core and pro from GPM Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliimak vitaliimak vitaliimak approved these changes

@jandroav jandroav Awaiting requested review from jandroav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayaliM0412 @vitaliimak @jandroav