Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 90,80,71: Convert Statements to runCommand and switch to 4x mongo driver #100

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

alexandru-slobodcicov
Copy link

@alexandru-slobodcicov alexandru-slobodcicov commented Feb 17, 2021

Fixes #90
Fixes #80
Fixes #71

┆Issue is synchronized with this Jira Bug by Unito

@alexandru-slobodcicov alexandru-slobodcicov merged commit 1ee2062 into main Feb 17, 2021
@alexandru-slobodcicov alexandru-slobodcicov deleted the issues/fix-71-80-4x-driver branch February 17, 2021 10:04
@jsonking
Copy link

Hi @alexandru-slobodcicov

I've been very busy the last couple of weeks, but am planning on raising more PR's for the conversions of the statements to runCommand when I get time; hopefully this weekend.
I noticed that #90 is now closed, and had 'help wanted' on it, so instead will mention this ticket in the new PR's.

Regards
Jason

@alexandru-slobodcicov
Copy link
Author

Hi @jsonking for now it is enough for migrating to runCommand as I created a integration test to check 4x compiled run with 3x driver provided. See .travis.yml. All looks good for now thus no urgency with the remaining's.
Sure you are welcome with new PRs in that area. Thank you.
Yes, please reference #90 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants