This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Dockerized #381
Open
Dockerized #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP - Adding back migrate check, working to unify services into one image * Unified utilities into one service * Renamed to api-service * Renaming to KEEP_ALIVE * Removing obsolete dockerfile * Pass full opts object to migrate * Renaming to service.dockerfile * Adding capabilities for running full system with docker compose * Invoking all services to run as full * Completed full system lifecycle, updated README * Formatting tweak to README * Reordered sections in README * Only trigger ci/cd tests on relevant changes * Fix on: syntax in test action
manicprone
force-pushed
the
dockerized
branch
from
cbd7407
to
36a9a88
Compare
manicprone
requested review from
AndonMitev,
b0b4456,
beemi,
bradleySuira,
Jennievon,
kraikov,
monokh and
tima-t
as code owners
trafico-bot
bot
added
✅ Approved
devaraj-s
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
LGTM ...
One suggestion we can have one docker file and create two builds in two ways one passing build params or we can
`FROM node:17-alpine3.12 as base
Create app directory
WORKDIR /usr/src/app
Install app dependencies
A wildcard is used to ensure both package.json AND package-lock.json are copied
where available (npm@5+)
COPY package*.json ./
RUN npm install
If you are building your code for production
RUN npm ci --only=production
Bundle app source
COPY . .
-------------------- API release ----------------
From base as release-api
EXPOSE 8080
CMD ["npm","run","api"]
-------------------- API scraper----------------
From base as release-scraper
CMD ["npm","run","woker"]`
docker build --target release-api -t atomicagent-api:latest .
docker build --target release-scraper -t atomicagent-worker:latest .
trafico-bot
bot
added
🔍 Ready for Review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.