fix: use WATCH_CONFIGMAPS workaround TDE-1016 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
requested review from
l0b0,
blacha,
amfage,
MDavidson17 and
Wentao-Kuang
paulfouquet
changed the title
blacha
approved these changes
Mar 26, 2024
l0b0
approved these changes
Mar 26, 2024
paulfouquet
deleted the
feat/use-workaround-stop-watching-configmaps-tde-1016
branch
paulfouquet
changed the title
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
…-1016 (#520) #### Motivation #498 has been using the wrong environment variable name to disable watching configmaps, so the issue is not fixed. #### Modification Use the correct [environment variable name](https://argo-workflows.readthedocs.io/en/stable/environment-variables/) #### Checklist - [ ] Tests updated - [ ] Docs updated - [x] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to reduce the Argo controller logs due to this issue, we can use this workaround for now.
Modification
Using
WATCH_CONFIGMAPS=falseworkaround implies upgrading Argo Workflows:3.5.5WATCH_CONFIGMAPSto Argo Controller environment variable tofalseNon regression tested on a NonProd cluster.
Checklist