Change NewNative funcs to accept unsafe.Pointer #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @muthukrishnan24 |
|
I agree not all structs need NewNative* exported. But some can be useful like SetNativeComparator |
|
@muthukrishnan24 yeah I agree with you. So lets update the PR: only expose NewNative for needed struct, hide others. |
|
Hi @linxGnu, updated the PR, exported NewNative for only needed structs |
linxGnu
requested changes
Sep 21, 2022
muthukrishnan24
force-pushed
the
native_create
branch
from
8ae2770 to
83e2e7d
Compare
muthukrishnan24
force-pushed
the
native_create
branch
from
83e2e7d to
4b89983
Compare
linxGnu
requested changes
Sep 22, 2022
| @@ -78,8 +79,8 @@ type MultiMerger interface { | |||
| } | |||
|
|
|||
| // NewNativeMergeOperator creates a MergeOperator object. | |||
| func NewNativeMergeOperator(c *C.rocksdb_mergeoperator_t) MergeOperator { | |||
| return &nativeMergeOperator{c} | |||
| func NewNativeMergeOperator(c unsafe.Pointer) MergeOperator { | |||
There was a problem hiding this comment.
We are exporting NewNative funcs for SliceTransform, CompactionFilter, MergeOperator
linxGnu
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes NewNative functions to accept unsafe.Pointer instead of C pointers