Skip to content

Added Lenovo Yoga 7 pen and tablet #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MonsieurLazar wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −0
Open

Added Lenovo Yoga 7 pen and tablet #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions data/lenovo-wacom-53fd.tablet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Lenovo
# Yoga 7 14AKP10
#
# sysinfo.8KDrpj1C9e.tar.gz
# https://github.com/linuxwacom/wacom-hid-descriptors/issues/586

[Device]
Name=Lenovo Wacom 53FD
ModelName=Lenovo Yoga Pen
DeviceMatch=i2c|056a|53fd;
Class=ISDV4
Width=12
Height=7
IntegratedIn=Display;System
Styli=@isdv4-aes;0x8113;
Copy link
Member

@whot whot Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about the compatibility of that pen, my gut feeling tells me this one should be wacom-compatible and thus part of the @isdv4-aes group. @jigpu?


[Features]
Stylus=true
Touch=true
Buttons=2
7 changes: 7 additions & 0 deletions data/wacom.stylus
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,3 +805,10 @@ Type=General
# Mangled tool ID for kernel < 6.20
PairedStylusIds=0x56a:0x10002;
AliasOf=0x56a:0x100a

[0x8113]
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylus ID section header format is inconsistent with all other entries in this file. All other stylus definitions in wacom.stylus use the vendor:product format (e.g., [0x56a:0x1], [0x56a:0x842]), but this entry uses only the product ID without the vendor prefix. This should likely be [0x56a:0x8113] to match the established pattern, where 0x56a is the Wacom vendor ID.

Suggested change
[0x8113]
[0x56a:0x8113]

Copilot uses AI. Check for mistakes.
Copy link
Member

@whot whot Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, apparently copilot is enabled here now. Anyway, it's correct with this comment, you need a vid:pid format for the pen now and the vid has to effectively match the tablet's vid.

Name=Lenovo Yoga Pen (0x8113)
Group=isdv4-aes
Buttons=2
Axes=Tilt;Pressure;
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing semicolon in the Axes field is inconsistent with the pattern used elsewhere in this file. When the Axes list ends with the last axis (no more axes follow), there should be no trailing semicolon. Other entries with just Tilt and Pressure (e.g., lines 111, 118, 125, 132, 136, 141) use Axes=Tilt;Pressure without a trailing semicolon.

Suggested change
Axes=Tilt;Pressure;
Axes=Tilt;Pressure

Copilot uses AI. Check for mistakes.
Type=Mobile