Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emby: mediainfo-plugin fix unzip command #949

Merged

Conversation

DaveO16176
Copy link

linuxserver.io


  • [X ] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds command options to the unzip command when the mod is checking to see if it should install and overwrite the biftool_linux.zip file.

Benefits of this PR and context:

Fixes the issue documented in [Issue #948]. Without this bug fix, users are forced to recreate the Emby container so the mod successfully runs.

How Has This Been Tested?

Built a local version with the new unzip options and the docker container successfully restarts.

Source / References:

@aptalca aptalca changed the base branch from master to emby-mediainfo-plugin September 2, 2024 20:24
Signed-off-by: aptalca <541623+aptalca@users.noreply.github.com>
@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_949

@aptalca
Copy link
Member

aptalca commented Sep 2, 2024

@DaveO16176
I made the BIF Tool install conditional
Please test the built PR and confirm it works
Thanks

Copy link
Author

@DaveO16176 DaveO16176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aptalca I tested the built PR and it works fine after the container is restarted.

I had originally thought of making the installation of the bif tool conditional like you did; however, if Roku ever updates the bif tool then the new version would never get downloaded, which is why I just added the -uo option to unzip. Roku hasn't updated the executable in 5 years so I don't think it's likely, but there could be a chance.

@aptalca
Copy link
Member

aptalca commented Sep 3, 2024

5 years is eternity. If it ever gets updated, we'll make a change then. No need to redownload it every time the container starts until then.

@aptalca aptalca merged commit 37e1511 into linuxserver:emby-mediainfo-plugin Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants